Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tutorials to root directory of the repo #102

Merged
merged 4 commits into from
Nov 25, 2021

Conversation

bamsumit
Copy link
Contributor

Signed-off-by: bamsumit [email protected]

Signed-off-by: bamsumit <[email protected]>
@bamsumit
Copy link
Contributor Author

bamsumit commented Nov 23, 2021

There does not seem to be tutorial links in the Readme. The links in lava-nc.org needs to be are fixed.

@bamsumit bamsumit linked an issue Nov 23, 2021 that may be closed by this pull request
Copy link
Contributor

@phstratmann phstratmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for moving the tutorials! I would appreciate if you could adjust the links accordingly. We link to the tutorials here:

  • the tutorials link to each other at various positions
  • we link to them from the documentation on lava-nc.org -> getting started with Lava

@bamsumit
Copy link
Contributor Author

Thanks for moving the tutorials! I would appreciate if you could adjust the links accordingly. We link to the tutorials here:

  • the tutorials link to each other at various positions
  • we link to them from the documentation on lava-nc.org -> getting started with Lava

Thanks for pointing that out. I already have a sprint checklist for it. I'll add one for tutorials as well. I'll create a separate issue and fix the links once this is merged. It's good to use the actual links rather than anticipate it beforehand.

Action item after this merge

  • Fix link in lava-nc.org
  • Fix link inside tutorials themselves

@phstratmann Did I miss anytihing?

Copy link
Contributor

@phstratmann phstratmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Could you just also change the links on lava-nc.org? To do so, you need to change them in the following file within the github:
lava-nc/lava-docs/getting_started_with_lava.rst

Signed-off-by: bamsumit <[email protected]>
@bamsumit
Copy link
Contributor Author

Thanks! Could you just also change the links on lava-nc.org? To do so, you need to change them in the following file within the github: lava-nc/lava-docs/getting_started_with_lava.rst

Yes, that's fixed here: lava-nc/lava-docs#16

Copy link
Contributor

@mathisrichter mathisrichter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@bamsumit bamsumit merged commit fec4803 into lava-nc:main Nov 25, 2021
@bamsumit bamsumit deleted the move_tutorials branch November 25, 2021 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tutorials in root level of the repo
3 participants