-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move tutorials to root directory of the repo #102
Conversation
Signed-off-by: bamsumit <[email protected]>
There does not seem to be tutorial links in the Readme. The links in lava-nc.org |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for moving the tutorials! I would appreciate if you could adjust the links accordingly. We link to the tutorials here:
- the tutorials link to each other at various positions
- we link to them from the documentation on lava-nc.org -> getting started with Lava
Thanks for pointing that out. I already have a sprint checklist for it. I'll add one for tutorials as well. I'll create a separate issue and fix the links once this is merged. It's good to use the actual links rather than anticipate it beforehand. Action item after this merge
@phstratmann Did I miss anytihing? |
Signed-off-by: bamsumit <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Could you just also change the links on lava-nc.org? To do so, you need to change them in the following file within the github:
lava-nc/lava-docs/getting_started_with_lava.rst
Signed-off-by: bamsumit <[email protected]>
Yes, that's fixed here: lava-nc/lava-docs#16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Signed-off-by: bamsumit [email protected]